Skip to content

Remove tutorials#63

Open
NiklasVin wants to merge 9 commits intoprecice:developfrom
NiklasVin:remove-tutorials
Open

Remove tutorials#63
NiklasVin wants to merge 9 commits intoprecice:developfrom
NiklasVin:remove-tutorials

Conversation

@NiklasVin
Copy link
Collaborator

Main changes of this PR

Removes tutorials from the adapter repository.

Motivation and additional information

Before creating a first release of the adapter, the tutorials should be moved to the tutorials repository. Cf. precice/tutorials#688 and precice/tutorials#687

Author's checklist

  • I updated the changelog file CHANGELOG.md if there are user-observable changes since the last release.
  • I squashed / am about to squash all commits that should be seen as one.

Reviewers' checklist

  • Does the changelog entry make sense? Is it formatted correctly?
  • Do you understand the code changes?

@NiklasVin NiklasVin self-assigned this Dec 27, 2025
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@IshaanDesai IshaanDesai marked this pull request as ready for review January 26, 2026 09:27
@IshaanDesai
Copy link
Member

An open question here is whether we still want to run the tutorial case in the CI, or if it would be better practice to add a system test for it. @MakisH what do you think?

@MakisH
Copy link
Member

MakisH commented Jan 26, 2026

These are independent: you might still want to run a tutorial that only requires FEniCSx (or the upcoming preCICE mock), as a lightweight system test in your regular CI.

A system test should definitely be added.

@IshaanDesai IshaanDesai linked an issue Feb 17, 2026 that may be closed by this pull request
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement FEniCSx version of FEniCS tutorials

3 participants