Open
Conversation
Member
|
An open question here is whether we still want to run the tutorial case in the CI, or if it would be better practice to add a system test for it. @MakisH what do you think? |
Member
|
These are independent: you might still want to run a tutorial that only requires FEniCSx (or the upcoming preCICE mock), as a lightweight system test in your regular CI. A system test should definitely be added. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
Removes tutorials from the adapter repository.
Motivation and additional information
Before creating a first release of the adapter, the tutorials should be moved to the tutorials repository. Cf. precice/tutorials#688 and precice/tutorials#687
Author's checklist
CHANGELOG.mdif there are user-observable changes since the last release.Reviewers' checklist