Add semicolon (';') as a sentence delimiter#12
Open
lafrenierejm wants to merge 1 commit intopreservim:masterfrom
Open
Add semicolon (';') as a sentence delimiter#12lafrenierejm wants to merge 1 commit intopreservim:masterfrom
lafrenierejm wants to merge 1 commit intopreservim:masterfrom
Conversation
Include ';' in the first regular expression grouping in `l:re_term`.
Collaborator
|
Thanks for the pull request. This is different behavior from the default sentence object. Let me think about this. It might be better as a configurable option. |
Contributor
Author
|
It might also be worth pointing out that the method of handling semicolons proposed by the PR does not correctly follow the grammatic definition of a sentence: it is incapable of recognizing the use of semicolons to delimit items in a list. |
Member
|
I agree this is useful in some circumstances but do not thing it should be the default. This should be arranged somehow similar to #17 so that it is a user configurable option. Perhaps after that is merged this could just document how to add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include ';' in the first regular expression grouping in
l:re_term.