Change contrast input background to bgColor-default#2907
Conversation
🦋 Changeset detectedLatest commit: e2fde47 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR deprecates the visual distinction of the input-contrast CSS class by changing its background color from a muted variant to the default background color. This aligns with an internal change that has already been tested and reduces the visual contrast difference for form inputs.
- Changes the
input-contrastbackground color from--bgColor-mutedto--bgColor-default - Adds a comment explaining the deprecation rationale
- Maintains the CSS class to avoid breaking changes while removing the visual distinction
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
|
|
||
| // Inputs with contrast for easy light gray backgrounds against white. | ||
| // changing the value to default as to not remove the class all together, but deprecate the visual distinction for "contrast" |
There was a problem hiding this comment.
The comment has a grammatical error. 'all together' should be 'altogether' (one word) when meaning 'completely' or 'entirely'.
| // changing the value to default as to not remove the class all together, but deprecate the visual distinction for "contrast" | |
| // changing the value to default as to not remove the class altogether, but deprecate the visual distinction for "contrast" |
| } | ||
|
|
||
| // Inputs with contrast for easy light gray backgrounds against white. | ||
| // changing the value to default as to not remove the class all together, but deprecate the visual distinction for "contrast" |
There was a problem hiding this comment.
The comment should start with a capital letter for consistency with standard comment formatting.
| // changing the value to default as to not remove the class all together, but deprecate the visual distinction for "contrast" | |
| // Changing the value to default as to not remove the class all together, but deprecate the visual distinction for "contrast" |
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
We've had this change staff shipped for awhile now (hubbers only) and it seems pretty low risk to change the color value of this field type.
Closes https://github.com/github/primer/issues/5905