Conversation
BREAKING CHANGE: The package was renamed from `@probot/serverless-lambda` to `@probot/adapter-aws-lambda-serverless` for consistency with the other adapters
BREAKING CHANGE: Usage changed
Before
```js
// handler.js
const { serverless } = require("@probot/serverless-lambda");
const appFn = require("./");
module.exports.probot = serverless(appFn);
```
After
```js
const { createLambdaFunction, createProbot } = require("@probot/adapter-aws-lambda-serverless");
const appFn = require("./");
module.exports.webhooks = createLambdaFunction(appFn, { probot: createProbot() });
```
| @@ -1,54 +1,37 @@ | |||
| { | |||
| "name": "@probot/serverless-lambda", | |||
| "name": "@probot/adapter-aws-lambda-serverless", | |||
There was a problem hiding this comment.
npm question: Does this mean the old name will disappear from registry? I mean, @probot/serverless-lambda@0.x.x won't exist anymore?
There was a problem hiding this comment.
not disappear, but it will be deprecated
lambda-function.js
Outdated
| // Ends function immediately after callback | ||
| context.callbackWaitsForEmptyEventLoop = false; | ||
|
|
||
| // this could will be simpler once we ship `verifyAndParse()` |
tcbyrd
left a comment
tcbyrd
left a comment
There was a problem hiding this comment.
Looks great! I really like the ProbotExports pattern and the API for this.
|
|
||
| return { | ||
| statusCode: error.status || 500, | ||
| error: "ooops", |
There was a problem hiding this comment.
Could this be more helpful? For example maybe point users at docs for Cloudwatch logs on how to debug?
There was a problem hiding this comment.
I'm not sure how? By adding a "documentation_url" key to the response? I'll create a follow up issue for further discussion to unblock this PR for now
Co-authored-by: Tommy Byrd <thomascbyrd@gmail.com>
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 participants
fixes #10
fixes #11
closes #24
fixes #25
fixes #36
fixes #39
fixes #54
fixes #58
BREAKING CHANGE: The package was renamed from
@probot/serverless-lambdato@probot/adapter-aws-lambda-serverlessfor consistency with the other adaptersBREAKING CHANGE: Usage changed
Before
After
View rendered README.md