Harden embed preview iframe with sandbox restrictions#3839
Open
aashu2006 wants to merge 2 commits intoprocessing:developfrom
Open
Harden embed preview iframe with sandbox restrictions#3839aashu2006 wants to merge 2 commits intoprocessing:developfrom
aashu2006 wants to merge 2 commits intoprocessing:developfrom
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
Contributor
Author
|
FYI this mirrors the sandbox configuration already used in the IDE preview. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Adds sandbox restrictions to the embed/standalone preview iframe to align its behavior with the existing IDE preview security model.
This is a minimal, non-functional hardening change; normal sketches continue to run as expected, while previously unrestricted behaviors are constrained.
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123