Feature/8097 get camera function#8105
Conversation
|
🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors! Thank You! |
perminder-17
left a comment
There was a problem hiding this comment.
Sorry for the delay in review, For the next time feel free to tag me on the PRs I can help reviewing them.
Actually, If we are thinking to add the activeCamera as a public API, so user can access it in sketch.js. But, here you only added it on RendererGL, not on the public p5 API (fn.activeCamera). Sketches won’t be able to call activeCamera() directly? What you think?
Resolves #8097
Changes:
This pull request introduces a new joint getter/setter function, activeCamera(), to the p5.RendererGL.prototype to standardize how the active camera is accessed and modified.
PR Checklist