rpm: Fix issue where no-cache is not respected#775
Merged
cpuguy83 merged 1 commit intoproject-dalec:mainfrom Oct 2, 2025
Merged
rpm: Fix issue where no-cache is not respected#775cpuguy83 merged 1 commit intoproject-dalec:mainfrom
cpuguy83 merged 1 commit intoproject-dalec:mainfrom
Conversation
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the ignore-cache build flag was not being properly respected in RPM and DEB package building workflows. The fix ensures that cache control is consistently applied throughout the build pipeline.
- Adds proper cache control to worker initialization and package building stages
- Ensures cache options are properly propagated through the build pipeline
- Fixes missing options propagation in DEB container building
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| targets/linux/rpm/distro/worker.go | Passes IgnoreCache option to Worker method call |
| targets/linux/rpm/distro/pkg.go | Adds cache control to BuildPkg and Build functions |
| targets/linux/rpm/distro/container.go | Adds cache control to BuildContainer function |
| targets/linux/deb/distro/container.go | Fixes missing options propagation to BuildPkg call |
cpuguy83
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes sure
--no-cacheand--no-cache-filteris respected for rpm-based targets.