[Feature] Add basic functionality to the mention_input_bar component

[ZhangHanDong]

Add basic functionality to the mention_input_bar component. For issue #278

The mention_input_bar component requires these modifications to the CommandTextInput component of Makepad to work :Makepad PR #651

TODO for the future:

1. Add a header to the user list to display the current number of users in the room.
2. Implement scrolling functionality for the user list.
3. Enable sorting for the user list to show currently online users.
4. Optimize performance and add a loading animation for the user list.

[ZhangHanDong]

The current error in CI with cargo check is because the dependent CommandTextInput component has not been updated to the latest version.
This PR needs to be merged. Makepad PR #651

[alanpoon]

1. Mentionable List should not appear when only the "@" is being typed, it should appear only after "@ and some match characters"
2. There should be a header "Users" at the top of the mention-able List
3. Mentionable List seems to contain current user and does not contain one remaining room user.

The typing textbox needs to also be able to show avatar, after selecting the mentioned user.
5.

The typing textbox is not able to send the correct format for the mentioning the user. After mentioning the user, the message should show a hyperlink for the mentioned user.

https://github.com/user-attachments/assets/9f43e74e-7f0d-4ed6-a69c-322396f5a2af
The highlighted background by the mouse should be same color as default highlighted mentionable user/

7. In the mentionable List, the user_id should have a "@" at the front.

[ZhangHanDong]

1. Mentionable List should not appear when only the "@" is being typed, it should appear only after "@ and some match characters"
2. There should be a header "Users" at the top of the mention-able List
3. Mentionable List seems to contain current user and does not contain one remaining room user.

The typing textbox needs to also be able to show avatar, after selecting the mentioned user. 5. The typing textbox is not able to send the correct format for the mentioning the user. After mentioning the user, the message should show a hyperlink for the mentioned user.

https://github.com/user-attachments/assets/9f43e74e-7f0d-4ed6-a69c-322396f5a2af The highlighted background by the mouse should be same color as default highlighted mentionable user/

7. In the mentionable List, the user_id should have a "@" at the front.

I don’t quite understand the reason for the first point.

I will continue to address the suggestions 2/6/7.

The others can be considered as features to be added in the future. This is just the initial version.

[kevinaboos]

The current error in CI with cargo check is because the dependent CommandTextInput component has not been updated to the latest version. This PR needs to be merged. Makepad PR #651

the Makepad PR has been merged in now.

[ZhangHanDong]

Add a header and other modifications to the popup user list. But it depends on the new changes of the CommandTextInput component. PR 663.

[ZhangHanDong]

Currently, getting room members will cache a list locally. Is there any room for improvement in this solution? @kevinaboos

[kevinaboos]

Thanks, great start on this complex feature!

First, there are quite a few places where you're using chars/characters, e.g., in find_mention_trigger_position(). We can't use characters, we always must use unicode graphemes instead.

Second, I don't think we need a cache for the list of members in a room -- that's not something that is used frequently, so we shouldn't really cache it. The room user list will be cached internally by the client's EventCache, so we don't really want to cache it separately.
We can just store the latest list of Vec<RoomMember>s in the MentionInputBar's room_members field (and optionally, also in the TimelineUiState struct if needed), we don't need a full cache.

[ZhangHanDong]

@kevinaboos

I have extracted the MentionableTextInput component and added the @ user functionality to the EditPane component.

To share the Members in the MentionableTextInput component across multiple components, I added the RoomMemberManager module, which provides a sub/pub mode, allowing multiple components dependent on the MentionableTextInput component to share member data without copying. The components currently sharing the MentionableTextInput component are RoomInputBar and EditPane.

The basic functionality is complete and the code can be reviewed first. Currently, the room_screen code is too large, and it needs to be merged as soon as possible to avoid too many conflicts, which would be difficult to modify.

Additionally, this pull request also depends on the merge of the makepad CommandTextInput pull request #663.

Finally, to unify everyone’s Rust fmt format, I added a rustfmt.toml, so that running cargo fmt locally will no longer result in a large number of unrelated files being modified.

[kevinaboos]

Thanks, overall I do think the PR looks good. Is it intended to be merged into main in the current state? There are tons of log statements and some things look a bit unfinished -- were you leaving those in until after my final approval, or should i remove myself or let you remove them now before final approval?

My main comment is that I don't think we need such a complicated solution for subscribing to a changed list of room members, since we already have so many mechanisms for inter-thread/task communication (actions, existing queues, channels), .... but we can always simplify that later, so let's not worry about it now. Plus, the code quality of your implementation is very good, so I'm inclined to leave it in for now since we may have future needs for inter-widget synchronization that actually justify that complex pub-sub implementation.

I appreciate the rustfmt configuration, but ideally we would have left those changes to be a separate PR. There are just so many unrelated formatting changes in this PR now that it makes it very hard for me to review the actual functionality changes in isolation from trivial formatting changes.

Can you undo a lot of the unrelated and unnecessary formatting changes?

Anyway, since this PR does introduce formatting config, my hand was forced so I did end up going through the entire docs of rustfmt. I have some thoughts and left comments in certain places in the code; also, here are some config options I'd like to add:

inline_attribute_width: 50 (or higher, we'll see)
imports_granularity: Crate
group_imports: StdExternalCrate

fn_single_line: true
format_generated_files: false

blank_lines_upper_bound: 3
hex_literal_case: Upper
reorder_modules: false
spaces_around_ranges: true
use_try_shorthand: true

Note: please don't apply rustfmt to all files in this PR -- let's do that later.

[ZhangHanDong]

I have made the corrections according to your review comments. @kevinaboos

Regarding the introduction of the sub/pub subscription pattern, I also wanted to take this opportunity to try out whether this solution is feasible, in preparation for future needs.

The rustfmt.toml content has also been added with the configurations you wanted to include. I did not run cargo fmt for this commit. Let’s keep the rustfmt.toml for future use.

P.S. There is now a dependency on this CommandTextInput PR #682 in makepad. A bug was found and has been resolved. Awaiting review.

[kevinaboos]

Thanks! Looks good now, appreciate all the effort that went into this!