Skip to content

pretty print FIB lookup IPs#11064

Closed
tomastigera wants to merge 1 commit intoprojectcalico:masterfrom
tomastigera:tomas-bpf-pretty-print-fib
Closed

pretty print FIB lookup IPs#11064
tomastigera wants to merge 1 commit intoprojectcalico:masterfrom
tomastigera:tomas-bpf-pretty-print-fib

Conversation

@tomastigera
Copy link
Contributor

Description

Related issues/PRs

Todos

  • Tests
  • Documentation
  • Release note

Release Note

TBD

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@tomastigera tomastigera requested a review from a team as a code owner September 23, 2025 19:06
Copilot AI review requested due to automatic review settings September 23, 2025 19:06
@tomastigera tomastigera added cherry-pick-candidate docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact labels Sep 23, 2025
@marvin-tigera marvin-tigera added this to the Calico v3.32.0 milestone Sep 23, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the debugging output for FIB (Forwarding Information Base) lookup operations by standardizing IP address formatting. The change replaces hexadecimal IP address display with a consistent IP_FMT format macro for both IPv4 and IPv6 addresses in debug messages.

  • Updates IPv4 debug output to use IP_FMT instead of hexadecimal format
  • Adds IPv6 debug output using the same IP_FMT format
  • Ensures consistent IP address formatting across both IP versions

Copy link
Member

@mazdakn mazdakn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomastigera tomastigera force-pushed the tomas-bpf-pretty-print-fib branch from c6c8ece to 45b5f13 Compare September 24, 2025 16:30
@github-actions
Copy link
Contributor

This PR is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale Issues without recent activity label Nov 23, 2025
@github-actions github-actions bot removed the stale Issues without recent activity label Mar 3, 2026
@tomastigera
Copy link
Contributor Author

Closing as obsolete — the fib_co_re.h change already landed on master, and fib_legacy.h is being removed in #12128.

@marvin-tigera marvin-tigera removed docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact labels Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants