Fix ep-to-host-action FV test flake in BPF mode#12169
Open
tomastigera wants to merge 1 commit intoprojectcalico:masterfrom
Open
Fix ep-to-host-action FV test flake in BPF mode#12169tomastigera wants to merge 1 commit intoprojectcalico:masterfrom
tomastigera wants to merge 1 commit intoprojectcalico:masterfrom
Conversation
tomastigera
added
docs-not-required
tomastigera
added
docs-not-required
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates a Felix FV test to avoid a startup race in BPF mode by explicitly waiting for Felix readiness before performing connectivity assertions.
Changes:
- Add a
WaitForReady()synchronization point afterTriggerDelayedStart()in the endpoint-to-host-action FV test. - Update the inline comment to document the BPF-mode timing issue being addressed.
tomastigera
force-pushed
the
tomas/fix-ep-to-host-bpf-flake
branch
from
75bf393 to
3b27a86
Compare
After TriggerDelayedStart(), the test immediately checked connectivity without waiting for Felix to finish programming. In BPF mode, the CTLB cgroup hook would allow connect() (BPF routes were in the map) but the tc programs weren't yet attached to the workload's cali interface, causing "no route to host" errors that exhausted the 10s connectivity checker timeout. Add WaitForReady() after TriggerDelayedStart() to ensure Felix has completed its first apply cycle before testing connectivity. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
tomastigera
force-pushed
the
tomas/fix-ep-to-host-bpf-flake
branch
from
3b27a86 to
0e254d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_BPF-SAFE_ endpoint-to-host-actionFV test that intermittently fails with "no route to host" in BPF modeTriggerDelayedStart(), the test was checking connectivity without waiting for Felix to finish programming the dataplaneconnect()(BPF routes were already in the map) but the tc programs weren't yet attached to the workload's cali interface, so packets fell through to kernel routing which had no route yetWaitForReady()afterTriggerDelayedStart()to ensure Felix completes its first apply cycle before testing connectivityTest plan
make -C felix fv-bpf GINKGO_FOCUS="endpoint-to-host-action"🤖 Generated with Claude Code