Modify output data for ease of use in visualisations#37
Modify output data for ease of use in visualisations#37lwr20 merged 9 commits intoprojectcalico:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds JUnit XML report generation and improves error handling to allow benchmark tests to continue running when individual tests fail. It also enhances output data for use in visualizations by adding timestamped output files and release stream tracking.
Changes:
- Added JUnit XML report generation capability with comprehensive test coverage
- Modified error handling from fatal exits to error logging with continuation, allowing all configured tests to run even when some fail
- Added timestamped output file naming for results and logs in run.sh
- Added ReleaseStream field to cluster details for better visualization filtering
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| run.sh | Adds JUnit report environment variable, pipes output to timestamped log files, and renames results/junit files with timestamps |
| pkg/junit/junit.go | New package implementing JUnit XML report generation from benchmark results |
| pkg/junit/junit_test.go | Comprehensive unit tests for JUnit report generation |
| pkg/config/config.go | Adds JUnitReportFile configuration option |
| pkg/cluster/cluster.go | Adds ReleaseStream field and removes unused retry import |
| cmd/benchmark.go | Changes fatal errors to non-fatal, adds cleanup before tests, and generates JUnit reports after each test |
| .gitignore | Adds patterns for timestamped output files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lwr20
force-pushed
the
lwr-visualisations
branch
from
36fa88b to
32e3415
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,345 @@ | |||
| // Copyright (c) 2026 Tigera, Inc. All rights reserved. | |||
|
|
|||
| // Licensed under the Apache License, Version 2.0 (the "License"); | |||
There was a problem hiding this comment.
Do we need to call it Apache v2?
This project is public but we have not explicitly called it out as open source yet.
| @@ -1,5 +1,7 @@ | |||
| #!/bin/bash | |||
| set -ex | |||
| set -o pipefail | |||
There was a problem hiding this comment.
nit: maybe we can combine both line 2 and 3 to be
| set -o pipefail | |
| set -exo pipefail |
There was a problem hiding this comment.
Will we be using the junit reports to upload to lens later or something else?
There was a problem hiding this comment.
Tiger-bench jobs will run as part of standard e2e jobs.
So yes, they'll be uploaded to Lens, and also show in the CI tool "tests" view.
Uh oh!
There was an error while loading. Please reload this page.