Skip to content

bug fix: agent may exit when yavirt has no guests#90

Merged
CMGS merged 1 commit into
projecteru2:masterfrom
DuodenumL:feature/migrate
Mar 4, 2022
Merged

bug fix: agent may exit when yavirt has no guests#90
CMGS merged 1 commit into
projecteru2:masterfrom
DuodenumL:feature/migrate

Conversation

@DuodenumL

Copy link
Copy Markdown
Contributor

yavirt的api里,如果没有guests / workloads的话会返回err,需要特殊处理一下

Comment thread manager/workload/load.go
return err
var workloadIDs []string
var err error
for {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里我会建议你用 NewTicker 啥的,注意资源泄露

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改啦

Comment thread runtime/yavirt/yavirt.go
@CMGS CMGS merged commit 9421845 into projecteru2:master Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants