Check for negative counter-like and guage histogram values.#338
Merged
Conversation
brian-brazil
force-pushed
the
openmetrics
branch
from
244ba2e to
c593db8
Compare
SuperQ
reviewed
Nov 21, 2018
SuperQ
approved these changes
Nov 21, 2018
Member
SuperQ
left a comment
SuperQ
left a comment
There was a problem hiding this comment.
Minor issue with some trailing spaces, otherwise LGTM.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
brian-brazil
force-pushed
the
openmetrics
branch
from
9186c38 to
19ef10c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@SuperQ per the last two meetings.