Raise the correct exception if the metrics are not observable#666
Merged
Conversation
daquinoaldo
reviewed
Jun 10, 2021
ocardia
approved these changes
Jun 10, 2021
Signed-off-by: Pietro De Nicolao <pd@bendingspoons.com>
daquinoaldo
approved these changes
Jun 10, 2021
Member
|
Hello, thank you for your PR and issue! I am taking a few days of time off, but plan to review it next week. |
csmarchbanks
approved these changes
Jun 15, 2021
Member
csmarchbanks
left a comment
csmarchbanks
left a comment
There was a problem hiding this comment.
Thanks! Most of these would error already, but a message like ValueError: counter metric is missing label values is much nicer than AttributeError: 'Counter' object has no attribute '_value'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always check that a metric is observable before changing its value. Fixes #665.