Support exemplars for single process mode#669
Conversation
csmarchbanks
force-pushed
the
exemplars
branch
2 times, most recently
from
c47b2c8 to
e6e5c2d
Compare
csmarchbanks
force-pushed
the
exemplars
branch
6 times, most recently
from
26dcc3b to
1bd82fb
Compare
Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
|
Hi @csmarchbanks @brian-brazil 👋🏽 Thx |
|
Hi @yacir, I am testing this out with some teammates soon internally. Unless some concerns come up I plan to merge and release this soon afterward. |
gerboland
left a comment
gerboland
left a comment
There was a problem hiding this comment.
Hey, I've given this a good test, works fine, output as expected. Code clean too. I'm happy to approve
|
@csmarchbanks @gerboland |
|
OpenMetrics does not allow gauges to have exemplars so they are not supported. It looks like custom collectors only have partial support right now, exemplars can only be specified for histograms. It would be good to add support for Counters and GaugeHistograms for custom collectors as well. Would you be willing to open an issue (or PR if you want) for support in custom collectors? |
5 participants
This PR adds support for exemplars for counters and histograms when instrumenting your code.