Skip to content

Prov: Improve performance of GetAllBalances and GetAccountsBalances.#616

Merged
SpicyLemon merged 2 commits into
release-pio/v0.50.xfrom
dwedul/get-bal-improvement
Mar 26, 2025
Merged

Prov: Improve performance of GetAllBalances and GetAccountsBalances.#616
SpicyLemon merged 2 commits into
release-pio/v0.50.xfrom
dwedul/get-bal-improvement

Conversation

@SpicyLemon
Copy link
Copy Markdown

@SpicyLemon SpicyLemon commented Mar 26, 2025 •
edited
Loading

Description

This PR improves the performance of GetAllBalances and GetAccountsBalances.

This is similar to cosmos#24148, but is being pulled into our fork because we need it sooner. Once we're basing our fork on a version that has that PR in it, we can remove this customization.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@SpicyLemon SpicyLemon enabled auto-merge (squash) March 26, 2025 22:22
@SpicyLemon
Copy link
Copy Markdown
Author

SpicyLemon commented Mar 26, 2025

I ran the following make targets locally and they all completed successfully:

  • make test
  • make test-sim-nondeterminism
  • make test-sim-import-export
  • make test-sim-after-import
  • make test-sim-multi-seed-short

arnabmitra
arnabmitra approved these changes Mar 26, 2025
View reviewed changes
Copy link
Copy Markdown

@arnabmitra arnabmitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@SpicyLemon SpicyLemon merged commit e1d2e0a into release-pio/v0.50.x Mar 26, 2025
SpicyLemon added a commit that referenced this pull request Apr 4, 2025
@SpicyLemon
Prov: Improve performance of GetAllBalances and GetAccountsBalances. (#…
039daec 
…616)

* Improve performance of GetAllBalances and GetAccountsBalances.

* Add changelog entry.
SpicyLemon added a commit that referenced this pull request Jul 15, 2025
@SpicyLemon @dependabot
@julienrbrt @alessio @zrbecker @alpe
Remove fee handler and fix post-handler error handling. (#618)
79d1c73 
* Remove the fee handler customization since the SDK added a post handler that does pretty much the same thing.

* Make DefaultGasLimit a variable instead of constant.

* Fix the post handler response code thing.

* Bring in SDK changes up to v0.50.12 and Mark v0.50.12-pio-1. (#614)

* build(deps): Bump github.com/cosmos/cosmos-db from 1.1.0 to 1.1.1 (cosmos#23030)

* build(deps): Bump github.com/cosmos/ledger-cosmos-go from 0.13.3 to 0.14.0 (cosmos#23029)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* feat(x/tx): add an option to encode maps using amino json (backport cosmos#23539) (cosmos#23540)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* feat(client/v2): add map support (backport cosmos#23544) (cosmos#23554)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* docs(keyring): add keyctl docs (backport cosmos#23563) (cosmos#23566)

Co-authored-by: Alessio Treglia <al@essio.dev>

* docs: correct explanation on how to set custom signer via depinject (backport cosmos#23654) (cosmos#23663)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* chore: remove unused orm module (backport cosmos#23633) (cosmos#23637)

Co-authored-by: Zachary Becker <zrbecker@gmail.com>

* Merge commit from fork

* Prevent empty groups

(cherry picked from commit 95090a0ec1f193104ba7d6d033a490d1515e54d8)

* Handle inflight proposals

(cherry picked from commit 855983471882068894ed7952b592ab3e61b464b9)

* No empty group with simulations

* Update changelog

* Set release date

* updates

* Update RELEASE_NOTES.md

* Update RELEASE_NOTES.md

---------

Co-authored-by: Alex Peters <alpe@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* Mark v0.50.12-pio-1 in the changelog.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Alessio Treglia <al@essio.dev>
Co-authored-by: Zachary Becker <zrbecker@gmail.com>

* Prov: Improve performance of GetAllBalances and GetAccountsBalances. (#616)

* Improve performance of GetAllBalances and GetAccountsBalances.

* Add changelog entry.

* Bring in SDK changes up to v0.50.13 and Mark v0.50.13-pio-1. (#615)

* Merge commit from fork

* Fix ABS061

* Use typed event

* Add changelog

* Review feedback

* Check for events

* Review feedback

* Remove unecessary code comments

* Set release date

* fix changelog

---------

Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>

* Add changelog entry.

* Put nothing back at the top of the changelog.

---------

Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>
Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>

* Add a bunch of logging.

* Revert "Add a bunch of logging."

This reverts commit 3baf4d3.

* Make the DefaultGasLimit a constant again (back to how the SDK has it).

* Add changelog entry.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Alessio Treglia <al@essio.dev>
Co-authored-by: Zachary Becker <zrbecker@gmail.com>
Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>
Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>
@SpicyLemon SpicyLemon mentioned this pull request Oct 17, 2025
Closed
13 tasks
@nagarajdivine nagarajdivine mentioned this pull request Dec 22, 2025
Closed
19 tasks
nagarajdivine added a commit that referenced this pull request Dec 23, 2025
@nagarajdivine
(x/bank) #616: update changelog with GetAllBalances and GetAccountsBa…
c90e050 
…lances optimization
@nagarajdivine nagarajdivine mentioned this pull request Dec 23, 2025
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arnabmitra arnabmitra arnabmitra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SpicyLemon @arnabmitra