Implement --timeout when running benchmarks #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the benchmark execution is exceeding the timeout execution, pyperf exits with an error 124. This error can be caught by pyperformance or other tool and report it back to the user.
vstinner
reviewed
Sep 24, 2024
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
I'm fine with the overall approach, but here is a review on the actual implementation.
vstinner
reviewed
Sep 24, 2024
vstinner
reviewed
Sep 25, 2024
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
Nice, the change works as expected :-)
$ python -m pyperf timeit 'import time; time.sleep(5)' --timeout=2
Timed out after 2 seconds
vstinner
reviewed
Sep 25, 2024
vstinner
reviewed
Sep 26, 2024
Member
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the benchmark execution is exceeding the timeout execution, pyperf exits with an error 124. This error can be caught by pyperformance or other tool and report it back to the user.