Skip to content

Fix #7152: Use to_native_string to handle binary method names in prepare_method#7185

Closed
codeforge19 wants to merge 1 commit intopsf:mainfrom
codeforge19:fix-binary-methods
Closed

Fix #7152: Use to_native_string to handle binary method names in prepare_method#7185
codeforge19 wants to merge 1 commit intopsf:mainfrom
codeforge19:fix-binary-methods

Conversation

@codeforge19
Copy link

Fixed a bug where byte-string methods were not being decoded correctly in models.py.
I replaced the direct conversion with to_native_string to ensure that methods like b'post' are correctly handled as "POST".

This fixes issue #7152.

@nateprewitt
Copy link
Member

Hi @codeforge19, this change is not necessary. The code works as expected already.

>>> to_native_string(b"get".upper())  
'GET'

In the future, we'd recommend validating your changes prior to opening PRs. It's also helpful to validate there isn't already an open PR for issues as there are other similar changes posted as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants