Fix #7152: Use to_native_string to handle binary method names in prepare_method#7185
Closed
codeforge19 wants to merge 1 commit intopsf:mainfrom
Closed
Fix #7152: Use to_native_string to handle binary method names in prepare_method#7185codeforge19 wants to merge 1 commit intopsf:mainfrom
codeforge19 wants to merge 1 commit intopsf:mainfrom
Conversation
Member
|
Hi @codeforge19, this change is not necessary. The code works as expected already. >>> to_native_string(b"get".upper())
'GET'In the future, we'd recommend validating your changes prior to opening PRs. It's also helpful to validate there isn't already an open PR for issues as there are other similar changes posted as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug where byte-string methods were not being decoded correctly in models.py.
I replaced the direct conversion with to_native_string to ensure that methods like b'post' are correctly handled as "POST".
This fixes issue #7152.