Skip to content

feat: include crededentials in graphql client#3976

Merged
pubkey merged 2 commits into
pubkey:masterfrom
marcoklein:feature/include-credentials-in-graphql-client
Sep 14, 2022
Merged

feat: include crededentials in graphql client#3976
pubkey merged 2 commits into
pubkey:masterfrom
marcoklein:feature/include-credentials-in-graphql-client

Conversation

@marcoklein

Copy link
Copy Markdown
Contributor

This PR contains:

  • A NEW FEATURE

Describe the problem you have without this PR

This is a feature for #3439

This Pull Request adds the option to pass the credential parameter to the underlying GraphQL client. Without it the application will not send any cookies to other domains since the credentials option is same-origin per default. See the spec documentation at https://fetch.spec.whatwg.org/#concept-request-credentials-mode

Todos

  • Tests
  • Documentation
  • Typings
  • Changelog

How should I update the changelog?

@pubkey

pubkey commented Sep 14, 2022

Copy link
Copy Markdown
Owner

Code looks good but there is nothing about the setCredentials() in the docs changes.
I will add teh changelog afterwards, you do not have to care about that.

@marcoklein

marcoklein commented Sep 14, 2022

Copy link
Copy Markdown
Contributor Author

What do you mean exactly? I updated the docs-src/replication-graphql.md to include some documentation but when I run npm run docs:build I get lots of changes in the docs folder so I thought you run that separately.

EDIT: saw that I had a typo in there. Updated the docs now.

@pubkey pubkey merged commit 5936d9b into pubkey:master Sep 14, 2022
pubkey added a commit that referenced this pull request Sep 14, 2022
@pubkey

pubkey commented Sep 14, 2022

Copy link
Copy Markdown
Owner

Great, merged.
Thank you for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants