Export ReplicationOptions type#4606
Merged
Merged
Conversation
Owner
|
Can you import them from In the future all type will be exported, see https://github.com/pubkey/rxdb/blob/master/src/index.ts#L33 |
Contributor
Author
|
No, that gives me I updated the PR to add the specific types to the list in index.ts, which also solves the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the great library! I just created rxdb-supabase on top of it to replicate to supabase.
The only problem I ran into was that the following types don't seem to be exported:
Of course, I could just duplicate all the fields in the Options type of my library, which arguably is not a terrible thing. But whenever you add a field to ReplicationOptions, it would require all downstream libraries to pass that field through as well. So I was wondering whether that's a deliberate design decision, or whether you want to add those types to the exports?
NOTE: I'm not saying this PR is the way to solve it, it probably exposes a lot of types that are implementation details. But it would be one way to solve my problem :)