Fixed content interference with toolbar

[TildaDares]

Fixes publiclab/plots2#9441

Before

After

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• PR body includes fixes #0000-style reference to original issue #
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

[welcome]

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Please make sure you've bumped up the version number in the repository's package.json file and that you've incorporated your changes in the /dist/ sub-directory.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

[gitpod-io]

[sahilsaha7773]

Hi @TildaDares! Thanks for your PR, can you please add the before and after screenshots here?

[waridrox]

Great work! 🎉@TildaDares 🚀 LGTM 😄. @cesswairimu pls could you confirm if the tests are failing due to #683 only, thanks :)

[sahilsaha7773]

Great work! LGTM!

[jywarren]

Nicely done here! Sorry i missed this!

[gitpod-io]

[jywarren]

Hmm. I'm seeing a lot of this type of error:

   - adds value to 'tags' key of editor.data, instead of overwriting it...
log: Failed to load resource: net::ERR_FILE_NOT_FOUND
   ...adds value to 'tags' key of editor.data, instead of overwriting it...X
     Expected '' to be 'cool,rad'. (1)
>> Expected '' to be 'cool,rad'. Error: Expected '' to be 'cool,rad'.
>>     at <Jasmine>
>>     at UserContext.<anonymous> (file:///home/runner/work/PublicLab.Editor/PublicLab.Editor/spec/javascripts/tags_module_spec.js:32:28)
>>     at <Jasmine>
     Expected 'first,' to be 'first,cool,rad'. (2)
>> Expected 'first,' to be 'first,cool,rad'. Error: Expected 'first,' to be 'first,cool,rad'.

I wonder... near the top i see:

log: Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.

Other recent pull requests don't show this. #718

Maybe we just can restart again? So strange, i'm sorry!

[jywarren]

I'm going to go ahead and merge this as we're otherwise stuck on Jasmine tests. This looks great, thank you!