Ephemera Box metadata not preserving when changed

[hackartisan]

Summary or User Story

ephemera box with id "ffac9f5e-d4c8-4e88-9898-25a2be9c9634" metadata is not re-preserving. Yesterday I manually ran preservation on it and the metadata version of the preservation object successfully updated to 1983. This morning:

figgy(prod)> resource.optimistic_lock_token.first.token
=> "2045"
figgy(prod)> preservation_object.metadata_version
=> "1983"

While 60 increments in the past 24 hours seems a bit high, it does appear that metadata changes are happening without corresponding preservation actions.

Related to #6835

Acceptance Criteria

• the metadata for this resource is preserved whenever it's updated

First step

This section can be completed by the DLS team

[hackartisan]

When I save the box via the UI, preservation occurs as expected and the preservation object updates its metadata_version.

[hackartisan]

Kim showed me how in this collection they digitize a "batch" of things, then ingest those as a box called "Batch X," then do QA and move them into more permanent boxes, then mark them complete.

The most recently preserved metadata for the box in question has more member_ids than the box currently has. So preservation likely isn't happening in here somewhere.

figgy/app/change_set_persisters/change_set_persister/append_to_parent.rb

Lines 47 to 52 in f8d4716

	def remove_from_old_parent
	return unless old_parent
	old_parent.thumbnail_id = nil if old_parent.respond_to?(:thumbnail_id) && (old_parent.thumbnail_id == post_save_resource.id)
	old_parent.member_ids = old_parent.member_ids - [post_save_resource.id]
	persister.save(resource: old_parent)
	end

[hackartisan]

I found a box that one of the resources had been moved into; the metadata version for its preservation object was also not correct.

figgy(prod)> fifty_one.optimistic_lock_token
=>
[#<Valkyrie::Persistence::OptimisticLockToken:0x00007f2bbc15a2b8
  @adapter_id=#<Valkyrie::ID:0x00007f2bbc15a2e0 @id="746f06acf4d573bebd8c8a500b398589">,
  @token="48">]
figgy(prod)> Wayfinder.for(fifty_one).preservation_object.metadata_version
=> "19"