Skip to content

[exception-reporting] Remove core package#1486

Merged
DeeDeeG merged 3 commits into
masterfrom
remove-exception-reporting
Mar 27, 2026
Merged

[exception-reporting] Remove core package#1486
DeeDeeG merged 3 commits into
masterfrom
remove-exception-reporting

Conversation

@confused-Techie

Copy link
Copy Markdown
Member

This is a core package inherited from the Atom days. Back in #40 I removed all functionality related to telemetry and remote crash reports.

At the time I left the exception-reporting package around under the idea we could always try to repurpose it for remote logging capabilities or something. But considering that hasn't been attempted or needed for the last 4 years, I think we are good to just delete this, which also removes the concern that a keen-eyed user may have that we are collecting telemetry without disclosing it.

Resolves #1013

@savetheclocktower savetheclocktower added this to the 1.132.0 milestone Mar 17, 2026

@DeeDeeG DeeDeeG left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okie dokie.

As you say, if in all of these ~4 years we have yet to circle back to reusing this package for anything, then yep. Probably fine to get rid of this code.

@DeeDeeG

DeeDeeG commented Mar 23, 2026

Copy link
Copy Markdown
Member

FWIW, I don't think any of these need anything, but just mentioning I have looked through all of these other hits for the package name in the repo:

% git grep exception-reporting
CHANGELOG.md:- Removed:  `fs-plus` from `exception-reporting` [@Sertonix](https://github.com/pulsar-edit/pulsar/pull/118)
docs/build-instructions/build-status.md:> - [exception-reporting](https://github.com/atom/atom/tree/master/packages/exception-reporting)
docs/build-instructions/build-status.md:| [Exception Reporting](https://github.com/atom/atom/tree/master/packages/exception-reporting) |  | [![Dependency Status](https://david-dm.org/atom/exception-reporting.svg)](https://david-dm.org/atom/exception-reporting) |
docs/rfcs/003-consolidate-core-packages.md:| **[exception-reporting]** | 5 | 0 | 0 | 2/6/18 |
docs/rfcs/003-consolidate-core-packages.md:[exception-reporting]: https://github.com/atom/exception-reporting
script/electron-builder.js:    "!**/{link,grammar-selector,json-schema-traverse,exception-reporting,one-light-ui,autoflow,about,go-to-line,sylvester,apparatus}/spec",
  • The electron-builder thing is just a path search pattern, of files to exclude from our build assets, so it doesn't hurt if it doesn't hit. It is extraneous and could be removed, but no harm if not removed IMO.
  • The whole file of docs/build-instructions/build-status.md seems probably wholly obsolete as documentation :| Untouched since Atom days, pretty much.
  • CHANGELOG.md and docs/rfcs/003-consolidate-core-packages.md contain historical content that reflects its time of authorship, and as such doesn't need revising.

@confused-Techie

Copy link
Copy Markdown
Member Author

@DeeDeeG Thanks for the approval! I could certainly see us removing exception-reporting from the electron-builder script, so I'll make sure to update when I get the time

@DeeDeeG DeeDeeG merged commit df2649a into master Mar 27, 2026
292 of 296 checks passed
@confused-Techie confused-Techie deleted the remove-exception-reporting branch March 28, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Telemetry / Bug Reporting

3 participants