Skip to content

Dependencies missing in CONTRIBUTING.md  #527

@Comradin

Description

@Comradin

Problem description

The documentation mentions to run through a list of steps to verify PR before submitting. Which is great. But the Makefile
makes use of the pulumictl binary, which isn't part of the general pulumi distribution and isn't mentioned in the file itself. And it
uses yarn, which may not everybody will have installed.

So, running the mentioned make command will result in two errors for the people like me, unaware of the dependencies.

Suggestions for a fix

I can provide a PR with an addition to the CONTRIBUTING.md that addresses this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions