fix(tags): change map types used in all tags to pulumi.Inputs of the map

[metral]

Fixes #146.

As showcased in the update examples/tags/index.ts, one can now supply pulumi.Inputs of the map types expected for the various resource tags. For example:

...
autoScalingGroupTags: cluster1.core.cluster.name.apply(clusterName => ({
    "myAutoScalingGroupTag1": "true",
    "myOtherAutoScalingGroupTag2": clusterName,
    [`k8s.io/cluster-autoscaler/${clusterName}`]: "true",
    "k8s.io/cluster-autoscaler/enabled": "true",
}));

[lukehoban]

I suspect (but am not sure) that the usage of cloudFormationTags needs to change to support this new type.

At least the usage as written currently is highly misleading, as it does an untyped cast into a type that is no longer guaranteed to be correct.

It’s possible that it still just works because of how things get serialized before passing to the resource provider - but it might make sense to fix up the types to be correct as well.

[lukehoban]

FWIW - I expect this is true for several of the other tag properties that have changed in this PR.

[metral]

Resolved using Pat's suggestion below

[metral]

@pgavlin Feedback has been addressed. PTAL

[lukehoban]

Resolved using Pat's suggestion below

I don't see any code that addresses the concern I was raising.

Code like this is no longer type-correct after this change. The ... throws away type information which hides the type mismatch, but args.nodeSecurityGroupTags is not assignable to aws.Tags. It's possible this doesn't matter, and that tags: itself allows the more general thing. But even then, the ..args.nodeSecurityGroupTags won't work as you can't splat through an Input<X>. This would need some sort of apply or Input<obj> merge function.

tags: <aws.Tags>{...args.tags, ...args.nodeSecurityGroupTags},

[lukehoban]

Code like this is no longer type-correct after this change.

Relatedly - it would help to have test coverage of some of the other kinds of tags that are being changed here - since they are consumed in a quite different way.

[metral]

Relatedly - it would help to have test coverage of some of the other kinds of tags that are being changed here - since they are consumed in a quite different way.

All the tags available are being tested in our tags example - do you see something missing that we are not testing?

[lukehoban]

All the tags available are being tested in our tags example - do you see something missing that we are not testing?

I don't see any cases that pass Output<{[key:string]: string}> or { [key: string]: Output<string>}. I expect those two cases will not work correctly.

[metral]

@lukehoban @pgavlin Feedback has been addressed, and a new test example/tests/tag-input-types has been added to test all variations of the pulumi.Input types for the tags:

• pulumi.Input<{ [key: string]: string }>
• { [key:string]: pulumi.Input<string> }
• pulumi.Input<{ [key: string]: pulumi.Input<string> }

PTAL

[lukehoban]

LGTM