Use Dir.glob with base parameter in acceptance tests#93
Merged
Conversation
This didn't work because using absolute paths doesn't work. By using relative paths in expect it can use the base parameter. It also enhances the be_an_empty_glob matcher to avoid a double glob because it avoids any potential race condition.
david22swan
approved these changes
Jun 25, 2024
Member
david22swan
left a comment
david22swan
left a comment
There was a problem hiding this comment.
Tests are passing and it reads fine so LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This didn't work because using absolute paths doesn't work. By using relative paths in expect it can use the base parameter.
It also enhances the
be_an_empty_globmatcher to avoid a double glob because it avoids any potential race condition.While cleaning up, it also fixes a typo in the
be_identical_as_soourcematcher.