Add support for modern keyrings#1128
Merged
Merged
Conversation
praj1001
requested review from
a team,
bastelfreak and
smortex
as code owners
|
|
|
Can you provide a better summary and title for this pull request? Includes #1105. |
Author
bastelfreak
reviewed
Sep 15, 2023
bastelfreak
reviewed
Sep 15, 2023
bastelfreak
reviewed
Sep 15, 2023
bastelfreak
reviewed
Sep 15, 2023
smortex
reviewed
Sep 21, 2023
smortex
left a comment
smortex
left a comment
Collaborator
There was a problem hiding this comment.
I did a first quick look without testing and apart some style issues, that looks great. This is really something that is needed and am looking forward for 👍
jamesps-ebi
suggested changes
Sep 22, 2023
bastelfreak
reviewed
Sep 22, 2023
praj1001
force-pushed
the
modern_debian_keyrings
branch
6 times, most recently
from
49c5de7 to
fa62402
Compare
kenyon
suggested changes
Sep 29, 2023
|
I think a PR title like "Add support for modern keyrings" would read better in the changelog. |
Co-authored-by: Kenyon Ralph <kenyon@kenyonralph.com>
Co-authored-by: Kenyon Ralph <kenyon@kenyonralph.com>
Co-authored-by: Kenyon Ralph <kenyon@kenyonralph.com>
Co-authored-by: Kenyon Ralph <kenyon@kenyonralph.com>
smortex
added a commit
to ccin2p3/puppet-syslog_ng
that referenced
this pull request
Jan 8, 2024
This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key in `/etc/apt/keyrings` and add a `signed-by` option to the `sources.list.d` entry.
smortex
added a commit
to choria-io/puppet-choria
that referenced
this pull request
Jan 8, 2024
This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key in `/etc/apt/keyrings` and add a `signed-by` option to the `sources.list.d` entry.
kenyon
added a commit
to kenyon/puppetlabs-postgresql
that referenced
this pull request
Jan 11, 2024
This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key in /etc/apt/keyrings and add a signed-by option to the sources.list.d entry.
smortex
added a commit
to ccin2p3/puppet-syslog_ng
that referenced
this pull request
Jan 11, 2024
This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key in `/etc/apt/keyrings` and add a `signed-by` option to the `sources.list.d` entry.
smortex
added a commit
to ccin2p3/puppet-syslog_ng
that referenced
this pull request
Jan 11, 2024
This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key in `/etc/apt/keyrings` and add a `signed-by` option to the `sources.list.d` entry.
smortex
added a commit
to choria-io/puppet-choria
that referenced
this pull request
Jan 11, 2024
This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key in `/etc/apt/keyrings` and add a `signed-by` option to the `sources.list.d` entry.
kenyon
added a commit
to kenyon/puppetlabs-postgresql
that referenced
this pull request
Jan 17, 2024
This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key in /etc/apt/keyrings and add a signed-by option to the sources.list.d entry.
smortex
added a commit
to ccin2p3/puppet-syslog_ng
that referenced
this pull request
Feb 13, 2024
This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key in `/etc/apt/keyrings` and add a `signed-by` option to the `sources.list.d` entry.
smortex
added a commit
to ccin2p3/puppet-syslog_ng
that referenced
this pull request
Feb 13, 2024
This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key in `/etc/apt/keyrings` and add a `signed-by` option to the `sources.list.d` entry.
smortex
added a commit
to ccin2p3/puppet-syslog_ng
that referenced
this pull request
Feb 13, 2024
This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key in `/etc/apt/keyrings` and add a `signed-by` option to the `sources.list.d` entry.
kenyon
added a commit
to kenyon/puppetlabs-postgresql
that referenced
this pull request
Apr 4, 2024
This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key in /etc/apt/keyrings and add a signed-by option to the sources.list.d entry.
kenyon
added a commit
to kenyon/puppetlabs-docker
that referenced
this pull request
Apr 16, 2024
This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key in `/etc/apt/keyrings` and add a `signed-by` option to the `sources.list.d` entry.
kali-brandwatch
pushed a commit
to brandwatch/puppetlabs-apt
that referenced
this pull request
May 10, 2024
…ings Add support for modern keyrings
kenyon
added a commit
to kenyon/puppetlabs-docker
that referenced
this pull request
Jun 7, 2024
This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key in `/etc/apt/keyrings` and add a `signed-by` option to the `sources.list.d` entry.
kenyon
added a commit
to kenyon/puppetlabs-docker
that referenced
this pull request
Sep 27, 2024
This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key in `/etc/apt/keyrings` and add a `signed-by` option to the `sources.list.d` entry.
vaol
pushed a commit
to vaol/puppetlabs-postgresql
that referenced
this pull request
Oct 13, 2024
This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key in /etc/apt/keyrings and add a signed-by option to the sources.list.d entry.
kenyon
added a commit
to kenyon/puppetlabs-docker
that referenced
this pull request
Jan 10, 2025
This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key in `/etc/apt/keyrings` and add a `signed-by` option to the `sources.list.d` entry.
kenyon
added a commit
to kenyon/puppetlabs-docker
that referenced
this pull request
May 5, 2025
This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key in `/etc/apt/keyrings` and add a `signed-by` option to the `sources.list.d` entry.
Henrik-Hansson
pushed a commit
to Henrik-Hansson/puppetlabs-postgresql
that referenced
this pull request
Jun 16, 2025
This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key in /etc/apt/keyrings and add a signed-by option to the sources.list.d entry.
Henrik-Hansson
pushed a commit
to Henrik-Hansson/puppetlabs-postgresql
that referenced
this pull request
Jun 16, 2025
This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key in /etc/apt/keyrings and add a signed-by option to the sources.list.d entry.
renepavlik
pushed a commit
to renepavlik/puppetlabs-docker
that referenced
this pull request
Sep 26, 2025
This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key in `/etc/apt/keyrings` and add a `signed-by` option to the `sources.list.d` entry.
Sharpie
pushed a commit
to Sharpie/puppetlabs-docker
that referenced
this pull request
Oct 25, 2025
This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key in `/etc/apt/keyrings` and add a `signed-by` option to the `sources.list.d` entry.
span786
pushed a commit
to puppetlabs/puppetlabs-docker
that referenced
this pull request
Dec 17, 2025
This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key in `/etc/apt/keyrings` and add a `signed-by` option to the `sources.list.d` entry.
span786
added a commit
to puppetlabs/puppetlabs-docker
that referenced
this pull request
Dec 17, 2025
…amily This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key in `/etc/apt/keyrings` and add a `signed-by` option to the `sources.list.d` entry. - Update dependencies and CI configurations for improved compatibility and performance
smortex
added a commit
to voxpupuli/puppet-php
that referenced
this pull request
May 13, 2026
This makes use of puppetlabs/puppetlabs-apt#1128 to store the public key in `/etc/apt/keyrings`. Use https:// url.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add apt::keyring defined type which creates modern-style keyrings. Just a PR with resolved comments and fixed parallel specs on PR #1105
Additional Context
Related Issues (if any)
Checklist
puppet apply)Courtesy Pull Requests (PRs)
We extend our gratitude to the original authors who have paved the way for us in the realm of open-source development. Special thanks to @jorhett for taking the initiative and demonstrating the handling of modern apt GPG keyrings in PR #1105. Additionally, we would like to express our appreciation to @jps-help for their contributions in PR #1120, specifically in the area of keyring management.
Your efforts are highly valued and greatly appreciated. Keep up the great work, and let's continue to drive innovation in the open-source community! Cheers!"