Conversation
|
I reverted previous changes to .fixtures.yml (change git:// to https://) since that doesn't seem to be needed anymore? If it is, I can go back and put the change back in. |
esalberg
force-pushed
the
log
branch
3 times, most recently
from
27decd1 to
f8d1c08
Compare
|
@esalberg , thanks for this! please rebase and add a test or two and we'd be glad to merge! |
esalberg
force-pushed
the
log
branch
2 times, most recently
from
5d4a0c2 to
dc55038
Compare
|
Rebased and added tests for chown, chmod, and logfile by copying the other get tests. Travis is showing rake errors based on no method last_comment - I can make the change suggested in PR #88 if it would help validate my tests. |
manifests/get.pp
Outdated
| } | ||
|
|
||
| if $chmod { | ||
| $myChmod = "--chmod=${chmod}" |
There was a problem hiding this comment.
myChmod and myLogfile both need to default to undef (see above for examples).
There was a problem hiding this comment.
Whoops, sorry about that. Done.
I think my Puppet Lint updated since I last committed changes to get.pp - it's complaining about variables containing uppercase letters. I updated the ones I added not to contain them, but there are 35 other errors. Is it okay to go through and update that as part of this PR, or would you prefer for me to disable lint temporarily?
There was a problem hiding this comment.
go ahead and just update yours for this one.
|
Appreciate the fix on the tests. Thanks for the merge! |
2 participants
No description provided.