Repository navigation
Conversation
Loosen the exact OpenTelemetry pins to compatible ranges and refresh Gemfile.lock. Turn off the Rack events handler of instrumentation-rack, which logs an unmatched context detach on every request from 0.26 on. Co-Authored-By: WOZCODE <contact@withwoz.com>
The OpenTelemetry pins in the gemspec change, so this is a major version. Co-Authored-By: WOZCODE <contact@withwoz.com>
isaac-jha
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P4DEVOPS-16617. Updates vmpooler's gem dependencies as far as JRuby 9.4 (Ruby 3.1, what prod runs) allows, and fixes the one regression the update causes. Against
main(3.8.1, after #705), with only the changes the update needs. This is the dependency part of #704 without the test-coverage work from #703.The newest OpenTelemetry instrumentation needs Ruby 3.3 or later, so "latest" is not reachable on this runtime. These are the highest versions that run on Ruby 3.1.
Changes
Version
3.8.1->4.0.0(lib/vmpooler/version.rb, thevmpoolerentry inGemfile.lock,CHANGELOG.md). Major, because the gemspec's OpenTelemetry requirements change and anything locking vmpooler with the old instrumentation gems has to move with it. The changelog entry is written by hand, not generated.Gemfile.lock: runtime and test gems updated to the newest versions the gemspec already allows. The lint toolchain (rubocop-ast,prism,parser) is untouched.vmpooler.gemspec: the exact=pins on the OpenTelemetry gems become patch-level ranges at the highest versions that run on Ruby 3.1:~>at the same versionlib/vmpooler.rb:use_rack_events: falsefor the Rack instrumentation. From instrumentation-rack 0.26 the Rack events handler detaches the OpenTelemetry context when Puma closes the response body, not where it was attached. OpenTelemetry then logscalls to detach should match corresponding calls to attachat ERROR, about three times per request.Verification
On this branch, JRuby 9.4.7 in Docker, with the committed
Gemfile.lock:bundle exec rspec specgives 893 examples, 0 failures. The runtime gem versions resolved there are identical to the committed lock.Real vmpooler API in containers with an explicit lockfile each, same config, Redis and Jaeger, 6 marked requests (measured on the P4DEVOPS-16617: update gem dependencies within what JRuby 9.4 can run (stacked on #703) #704 branch, same dependency set):
Not verified
prismneeds a C compiler that the test container does not have, so the lint gems were not installed. CI runs it.use_rack_events: false.spec/unit/vmpooler_config_spec.rbis added by P4DEVOPS-16617: raise test coverage to 93% and fix bugs it found #703 and does not exist on main. P4DEVOPS-16617: update gem dependencies within what JRuby 9.4 can run (stacked on #703) #704 carries the spec. Say if you want a small spec file added here.Not in this PR
docker/Gemfile.lock.Relation to other PRs
🧙 Built with WOZCODE