Add missing deps#205
Merged
thomashoneyman merged 6 commits intopurescript-contrib:mainfrom Jul 28, 2021
Merged
Conversation
Contributor
|
This looks good, though it's now revealing some unused name errors -- would you mind taking a look at those? Thank you! |
d65083f to
baaabae
Compare
baaabae to
3e77de4
Compare
Contributor
Author
|
Sorry for the force push, got confused which repo I was in 😅 |
Contributor
|
No worries 😆 Also, I don't know if you saw it yet, but I updated the original issue to recommend not worrying about the bower.json files. They're a bit of a mess and you can just leave them as-is. I can tweak them as needed before publishing the library; they aren't used in local development anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This adds missing dependencies listed when running
spago build(see: purescript-contrib/governance#43)Output from running
spago buildbefore these changesChecklist: