-
Notifications
You must be signed in to change notification settings - Fork 8
0.7 stream updates #44
Conversation
|
Okay. I realized that this is not quite ready yet in terms of the stream handling. I will push more updates on this later today. |
|
Ah, sorry I haven't had a chance to look at it yet either. The |
|
No problem at all. Stay tuned for further updates. |
Migrating back to a stream implementation for the tasks to allow conventient piping with other streams such as `gulp.dest`.
|
@garyb I know this is a big switch, but I've migrated back to a stream interface for the tasks. For the I am still looking into issue #45, but testing with gulp the errors seem to be handled okay. What do you think? |
|
Looks great! Everything works perfectly on a test project I have locally 👌. We have to pipe Thanks very much for fixing up my mess 😉 Do you want to fix #45 before releasing? I'd be happy for it to go out as-is if it's not a major problem, it would be good to have a non-RC version of the plugin out there that works with 0.7. |
|
Thanks for taking a look and testing. Yes, we do need to pipe And thank you for kick-starting all of these changes. #45 doesn't seem to be posing a problem in my testing so I think pushing a release as it stands now would be good. I can do a release at lunchtime today. |
|
👍 |
Merging stream refactoring for 0.7 updates.
@garyb I just have to update the README and do a bit more testing. But these changes should make the streaming possible for
pscBundle. For thepscitask, I just wrote the.pscifile. Should this push out a stream instead? We can do that, but I think it works to output the file.I will make the remaining changes tomorrow.