Fix lockup text not being ellipsed in some flex contexts#151
Merged
arthurxavierx merged 1 commit intomasterfrom May 22, 2020
Merged
Fix lockup text not being ellipsed in some flex contexts#151arthurxavierx merged 1 commit intomasterfrom
arthurxavierx merged 1 commit intomasterfrom
Conversation
Contributor
|
This seems ok to me, but it feels like it might risk triggering one of the iOS flex bugs we saw recently, where things shrink right down to their |
Contributor
Author
|
Oh, I hadn't heard of that bug yet. Yeah, that sounds risky. Unfortunately I don't have access to an iOS device. Could you help me with testing, please? |
maddie927
approved these changes
May 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.