Skip to content

docs: fix readthedocs build #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JonnyWong16 merged 1 commit into from
Oct 12, 2023
Merged

docs: fix readthedocs build #1266

JonnyWong16 merged 1 commit into from
Oct 12, 2023

Conversation

@ReenigneArcher
Copy link
Contributor

@ReenigneArcher ReenigneArcher commented Oct 6, 2023 •
edited
Loading

Description

This PR fixes readthedocs build. See here for more information about the breaking change -> https://blog.readthedocs.com/drop-support-system-packages/

There is also an option on readthedocs to build pull requests, you might consider enabling that in order to catch issues like this faster.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@JonnyWong16 JonnyWong16 merged commit f8dc6f8 into pushingkarmaorg:master Oct 12, 2023
@ReenigneArcher ReenigneArcher deleted the docs-fix-readthedocs-build branch October 14, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonnyWong16 JonnyWong16 JonnyWong16 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ReenigneArcher @JonnyWong16