Refactor image info #1721
Open
Refactor image info #1721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersonhc
force-pushed
the
refactor-img-info
branch
from
16910ab to
5b6c50b
Compare
Lucas-C
reviewed
Jan 22, 2026
Lucas-C
reviewed
Jan 22, 2026
andersonhc
force-pushed
the
refactor-img-info
branch
from
5b6c50b to
bfe2c00
Compare
andersonhc
force-pushed
the
refactor-img-info
branch
from
bfe2c00 to
42d6925
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors image info storage to use
dataclasseswith clearer field names, improving readability and maintainability while enabling stronger typing and reducing the need for type asserts/ignores.For backward compatibility, the public
FPDF.image()API now converts the returned image info back to the legacy dict format with historical keys.Checklist:
In case of a new feature, docstrings have been added, with also some documentation in the
docs/folderA mention of the change is present in
CHANGELOG.mdThis PR is ready to be merged
By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.