Repository navigation
write_html: stop a rowspan past the last row at the last row, like br… - #2031
Merged
andersonhc merged 1 commit intoOct 15, 2026
Merged
Conversation
andersonhc
approved these changes
Oct 15, 2026
andersonhc
left a comment
andersonhc
left a comment
Collaborator
There was a problem hiding this comment.
Good to merge.
Limitation: The current clamp counts rows through the end of the whole table rather than the containing thead, tbody, or tfoot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
<td rowspan="99">near the end of a table, as written by many HTML generators, madewrite_html()raiseFPDFException: Rowspan extends beyond end of table. The HTML spec says a rowspan that goes past the last row ends at the last row, which is what browsers draw.write_html()now applies that to the cells before rendering.Tableitself still raises for programs that build tables directly. Added tests comparing against the equivalent valid rowspan.