Repository navigation
write_html: keep the default bullet for an empty or unknown <ul type> - #2055
Merged
Merged
Conversation
andersonhc
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty or unknown
typeon a<ul>, such astype=""or a misspelledtype="disk", madewrite_html()raiseNotImplementedError: Unsupported type. Browsers ignore it and keep the default disc, andwrite_html()already does the same for an unknown<ol type>.write_html()now keeps the default bullet (ul_bullet_char) for such a type. A known keyword, in any case, and a single character used as the bullet work as before, and an invalidul_bullet_charpassed towrite_html()still raises, because the fallback only applies to the HTML attribute. Added tests for empty, blank and unknown types, and for the fallback to a customul_bullet_char.