Repository navigation
ink_annotation: compute the rectangle's x from the x coordinates - #2068
Merged
Merged
Conversation
andersonhc
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FPDF.ink_annotation()builds the annotation rectangle withx=y_min, so the horizontal position of/Rectcame from the y coordinates of the path. The rectangle did not enclose the drawn path: intest/ink_annotation.pdf, the path spans x = 113-283pt but/Rectwas[629.29 629.29 799.37 771.02], entirely to the right of the 595pt-wide A4 page. Viewers use/Rectto place and hit-test the annotation.It now uses
x=x_min. The two reference PDFs that contain an ink annotation (test/ink_annotation.pdf,test/encryption/encryption_aes256.pdf) change only in/Rect(now[113.39 629.29 283.46 771.02]) and the derived/ID. Addedtest_ink_annotation_rect_encloses_the_pathnext totest_ink_annotation, and a CHANGELOG entry.