Repository navigation
BUG: Check the value assigned to print_scaling - #4011
Merged
stefan6419846 merged 1 commit intoAug 26, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4011 +/- ##
=======================================
Coverage 98.00% 98.00%
=======================================
Files 57 57
Lines 11120 11120
Branches 2084 2084
=======================================
Hits 10898 10898
Misses 124 124
Partials 98 98 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stefan6419846
approved these changes
Aug 26, 2026
stefan6419846
requested changes
Aug 26, 2026
stefan6419846
left a comment
stefan6419846
left a comment
Collaborator
There was a problem hiding this comment.
Could you please check and resolve the merge conflict?
/PrintScaling was declared with an empty list of acceptable values, so any name was written through and the generated docstring read 'Acceptable values: []'. The spec allows /None and /AppDefault, which is what the viewer preferences documentation shows. direction and duplex beside it are declared with their values and reject anything else.
RavSinghChandan
force-pushed
the
validate-print-scaling
branch
from
August 26, 2026 08:50
21ec78a to
6c95c1b
Compare
Contributor
Author
|
Rebased onto main. The conflict was just my tests landing at the end of the same file as the ones from #4010, so both are there now. |
stefan6419846
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/PrintScalingis declared with an empty list of acceptable values:So any name is written through unchecked, and the generated docstring reads "Acceptable values: []".
The spec allows
/Noneand/AppDefault, which is whatdocs/user/viewer-preferences.mdshows.directionandduplexbeside it are declared with their values and reject anything else.Reverting the change fails the three new tests