Repository navigation
BUG: Use current text matrix for visitor_text - #4062
Conversation
|
I noticed that the failing CI job is The failure appears to be outside the code path modified by this PR, which only affects |
|
Regarding #4062 (comment): In the past, this was a temporary flakiness of CI (like with some other files). As it relied on external URLs and thus can hopefully be made more reliable, I am currently changing this to use a local copy. After this, CI should hopefully pass again. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4062 +/- ##
=======================================
Coverage 98.10% 98.11%
=======================================
Files 59 59
Lines 11480 11476 -4
Branches 2148 2147 -1
=======================================
- Hits 11263 11260 -3
Misses 122 122
+ Partials 95 94 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
The remaining failure is a timeout in |
## What's new ### Security (SEC) - Further restrict FlateDecode recovery (#4073) by @stefan6419846 - Limit entry count for TrueType and Type1 font `/Widths` (#4072) by @stefan6419846 - Limit allowed length of tokens in parse_bfchar (#4071) by @stefan6419846 ### Bug Fixes (BUG) - Use current text matrix for visitor_text (#4062) by @r-kamei - Repeat the letter for /S /A and /S /a page labels past Z (#4065) by @youdie006 - Use font color for FreeText default appearance (#4051) by @Yuki9814 ### Robustness (ROB) - Fix compatibility with fonttools < 4.58.0 (#4050, #4059) by @MeggyCal and @stefan6419846 ### Documentation (DOC) - Use combined matrix in visitor examples (#4066) by @r-kamei [Full Changelog](6.18.0...6.18.1)
Summary
Fix #2932.
visitor_text()could receive a stale text matrix when a new textfragment begins with a synthesized leading space.
Tests
visitor_text_position.pdftest_visitor_text_uses_current_text_matrixFails before the fix, passes after the fix.
AI Usage
Development assistance: Microsoft Copilot (GPT-5).