Repository navigation
ROB: Do not crash on removing annotations when they are not an array - #4349
Open
RavSinghChandan wants to merge 1 commit into
Open
RavSinghChandan wants to merge 1 commit into
RavSinghChandan wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4349 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 59 59
Lines 12123 12128 +5
Branches 2305 2306 +1
=======================================
+ Hits 11979 11984 +5
Misses 70 70
Partials 74 74 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writer.remove_annotations()andwriter.remove_links()raisedTypeError: object of type 'NumberObject' has no len()when a page's/Annotsis a number, andAttributeError: 'str' object has no attribute 'get_object'when it is a string. An entry of/Annotsthat is not a dictionary made them fail too.A
/Annotsthat is not an array now logs "Annotations are not an array: ...", likepage.annotationsdoes since #4046, and is left as is. An entry that is not a dictionary has no subtype: it is kept when filtering by subtype and removed with all the annotations.Added
test_remove_annotations__annotations_are_not_an_arrayandtest_remove_annotations__entries_are_not_dictionaries; both fail on main