Skip to content

[Repo Assist] fix: replace bare except clauses with specific NetworkX exceptions #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Repo Assist] fix: replace bare except clauses with specific NetworkX exceptions #1421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dowhy/causal_identifier/id_identifier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ def identify_effect_id(

try:
tsort_node_names = OrderedSet(list(nx.topological_sort(graph))) # topological sorting of graph nodes
except:
except nx.NetworkXUnfeasible:
raise Exception("The graph must be a directed acyclic graph (DAG).")

return __adjacency_matrix_identify_effect(
Expand Down
2 changes: 1 addition & 1 deletion dowhy/utils/graph_operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ def find_predecessor(i, j, g):
try:
path = shortest_path(u, pa, i)
return pa
except:
except nx.NetworkXNoPath:
pass
return None

Expand Down
Loading