Merged
Conversation
alex
reviewed
Dec 6, 2024
Member
alex
left a comment
alex
left a comment
There was a problem hiding this comment.
In addition to adding the implementations to the concrete classes, you'll want to add them to the ABCs for each of these key types as well.
Member
|
I think it's fine to load a weak key and skip on FIPS and be marginally faster. |
Contributor
Author
|
Thanks, I reverted back to loading the key from a file and added a I also added abstract methods to the abstract base classes. The ABCs for the public keys were also missing the abstract version of the |
alex
approved these changes
Dec 6, 2024
reaperhulk
added a commit
that referenced
this pull request
May 19, 2025
@Yossarian pointed out that we missed this breaking change #12110
alex
pushed a commit
that referenced
this pull request
May 19, 2025
* add missing 45.0.0 changelog entry @Yossarian pointed out that we missed this breaking change #12110 * Update CHANGELOG.rst * oops
alex
pushed a commit
to alex/cryptography
that referenced
this pull request
May 25, 2025
* add missing 45.0.0 changelog entry @Yossarian pointed out that we missed this breaking change pyca#12110 * Update CHANGELOG.rst * oops
reaperhulk
added a commit
that referenced
this pull request
May 25, 2025
* Rename PBES1 types to better match their origins in the spec (#12976) PBEParams is defined in RFC 8018 as going with PBES1, but then its also used by PKCS#12 ciphers in RFC 7292. * add vector and test for longer salt length in PBE (#12977) * add vector and test for longer salt length in PBE * Update docs/development/test-vectors.rst Co-authored-by: Alex Gaynor <alex.gaynor@gmail.com> --------- Co-authored-by: Alex Gaynor <alex.gaynor@gmail.com> * fixes #12949 -- added support for decrypting des-cbc-md5 keys (#12978) * add missing 45.0.0 changelog entry (#12946) * add missing 45.0.0 changelog entry @Yossarian pointed out that we missed this breaking change #12110 * Update CHANGELOG.rst * oops * changelog + version bump * add pbeWithMD5AndDES-CBC test vector (#12956) * typo * fix documentation for the decrepit algorithms module (#12953) --------- Co-authored-by: Paul Kehrer <paul.l.kehrer@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for copying private keys, such as the RSAPrivateKey. This resolves issue #11859.
Wasn't sure if it was better to generate a stronger key for
DHPrivateKeyin the tests or to load a smaller one from a file and use@pytest.mark.skip_fips(reason="non-FIPS parameters")to get it to pass on FIPS; settled for the first option, to have better test coverage in exchange of speed, but let me know if you'd prefer it the other way around. UPDATE: Based on feedback in the review changed to loading the key from a file and using skip_fips for that test.