Repository navigation
reject unsuccessful ocsp responses that carry response bytes - #15901
Open
jmestwa-coder wants to merge 2 commits into
Open
jmestwa-coder wants to merge 2 commits into
jmestwa-coder wants to merge 2 commits into
Conversation
alex
reviewed
Nov 5, 2026
| # Change the responseStatus from successful (0) to tryLater (3), | ||
| # leaving the BasicOCSPResponse in place. | ||
| assert data[4:7] == b"\x0a\x01\x00" | ||
| data[6] = 3 |
Member
There was a problem hiding this comment.
This is not the right way to do this -- we want a checked in vector with teh right bytes, not a mutation of an existing vector.
Contributor
Author
There was a problem hiding this comment.
Makes sense. Added x509/ocsp/resp-unsuccessful-response-bytes.der (resp-sha256.der with the status set to tryLater), documented it in test-vectors.rst, and the test now just loads it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
load_der_ocsp_responserejects a successful response with noresponseBytes, but not the reverse:tryLater,unauthorizedor other non-successful status that still carries aBasicOCSPResponseloads fineValueErroras documented, e.g.resp-sha256.derwith the status flipped totryLaterreportsTRY_LATERandcertificate_statusGOODresponseByteswith a successful status, andresponseStatussits outside the signed dataNow raises
ValueErrorat load time, with a regression test and a changelog entry.