Closed
Conversation
See: pyca#4197 Signed-off-by: Christian Heimes <[email protected]>
alex
requested changes
Sep 26, 2018
| (OPENSSL_VERSION_NUMBER >= 0x10100000 && !CRYPTOGRAPHY_IS_LIBRESSL) | ||
| #define CRYPTOGRAPHY_OPENSSL_110F_OR_GREATER \ | ||
| (OPENSSL_VERSION_NUMBER >= 0x1010006f && !CRYPTOGRAPHY_IS_LIBRESSL) | ||
| #define CRYPTOGRAPHY_OPENSSL_111_OR_GREATER \ |
Member
There was a problem hiding this comment.
This isn't actually used, please remove it.
| static const long Cryptography_HAS_CIPHER_DETAILS = 1; | ||
| #endif | ||
|
|
||
| #if CRYPTOGRAPHY_OPENSSL_LESS_THAN_111 |
Member
There was a problem hiding this comment.
This attribute needs to be available only when it's really present in OpenSSL. See #4476 for all the places that need editing.
Member
|
Replaced by #4555 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #4197
Fixes: #3526
Signed-off-by: Christian Heimes [email protected]