Skip to content

Fixing issue #798 #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reaperhulk merged 9 commits into from
Oct 18, 2020
Merged

Fixing issue #798 #907

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9ac2ba1
Fixing issue #798, thanks to @reaperhulk; removing undocumented '%s' …
Apr 6, 2020
afc97fd
Failing in windows
Apr 6, 2020
af8a97b
Revert afc97fdae892642c93288f406308292609f28a7c not intended for this PR
Apr 6, 2020
faae732
Import at the top of the file
Apr 6, 2020
bc9ae8d
Update import order
jalberdi004 Apr 6, 2020
c6f5abc
Merge branch 'master' of git://github.com/pyca/pyopenssl
Jun 19, 2020
cd3e476
Merge branch 'master' of github.com:jalberdi004/pyopenssl
Jun 19, 2020
331f171
Merge remote-tracking branch 'upstream/master'
Oct 17, 2020
6768c7b
reformatted with black
Oct 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/OpenSSL/crypto.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1641,10 +1641,11 @@ def set_time(self, vfy_time):
:param datetime vfy_time: The verification time to set on this store.
:return: ``None`` if the verification time was successfully set.
"""
import calendar
Copy link
Copy Markdown
Member

@alex alex Apr 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imports should go at teh top of the file

Copy link
Copy Markdown
Contributor Author

@jalberdi004 jalberdi004 Apr 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved

param = _lib.X509_VERIFY_PARAM_new()
param = _ffi.gc(param, _lib.X509_VERIFY_PARAM_free)

_lib.X509_VERIFY_PARAM_set_time(param, int(vfy_time.strftime('%s')))
_lib.X509_VERIFY_PARAM_set_time(param, calendar.timegm(vfy_time.timetuple()))
_openssl_assert(_lib.X509_STORE_set1_param(self._store, param) != 0)


Expand Down