add **encoding** argument in netCDF4 backend#10372
Open
wqshen wants to merge 2 commits intopydata:mainfrom
Open
add **encoding** argument in netCDF4 backend#10372wqshen wants to merge 2 commits intopydata:mainfrom
wqshen wants to merge 2 commits intopydata:mainfrom
Conversation
…ile with non-ASCII path or filename and keep consistent behavior with upstream netcdf4 library
|
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
for more information, see https://pre-commit.ci
Contributor
|
Nice, can you add a test here please? xarray/xarray/tests/test_backends.py Line 2037 in d589df1 It can simply roundtrip a simple dataset to a file with a filename that doesn't work today. |
Contributor
|
How is this handled in the light of this comment #9282 (comment) by @dcherian? |
Contributor
|
Hah! Probably good to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add encoding argument in netCDF4 backend to support reading NetCDF file with non-ASCII path or filename.
The behavior is consistent with upstream netCDF4 library, default path encoding is set to
sys.getdefaultfileencoding().encodingparameter when reading netCDF files with xarray #10357 Cannot read a nc file that contains the diacritic mark tilde (á) in the path #8531