Fix _get_default_engine_netcdf to check for h5netcdf#10557
Merged
dcherian merged 5 commits intopydata:mainfrom Jul 30, 2025
Merged
Fix _get_default_engine_netcdf to check for h5netcdf#10557dcherian merged 5 commits intopydata:mainfrom
_get_default_engine_netcdf to check for h5netcdf#10557dcherian merged 5 commits intopydata:mainfrom
Conversation
The current implementation only checks for `scipy` and `netCDF4`. This adds the necessary check for `h5netcdf`. Switches to using `importlib.util.find_spec`, as recommended by https://docs.python.org/3/library/importlib.html#importlib.util.find_spec The unit test temporarily removes the other two backend options, then checks that `h5netcdf` is used. Closes pydata#10401
dcherian
reviewed
Jul 25, 2025
Contributor
|
LGTM. Can you merge |
dcherian
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation only checks for
scipyandnetCDF4. This adds the necessary check forh5netcdf.Switches to using
importlib.util.find_spec, as recommended by https://docs.python.org/3/library/importlib.html#importlib.util.find_specThe unit test temporarily removes the other two backend options, then checks that
h5netcdfis used.api._get_default_engine_netcdfdoes not check forh5netcdf#10401whats-new.rstapi.rst