Import h5netcdf.core to use EnumType #10779
Conversation
|
@kmuehlbauer would you be willing to provide some advice here? The min-deps CI check is failing because |
|
@maxrjones EnumType was released with h5netcdf 1.4.0 in October 2024. |
|
This is also mentioned in a comment in the #9509 PR. Maybe you need to conditionally import depending on version? I can have a closer look tomorrow. |
ah, ok thanks for this clarification. It seems we're close, but not quite to the 12 month mark for minimum dependencies |
kmuehlbauer
left a comment
There was a problem hiding this comment.
Thanks @maxrjones , I've made a mental note, to not forget to remove this in October.
This PR fixes an import issue with
h5netcdf.core.EnumType. Recent Python versions require explicit submodule imports, soimport h5netcdffollowed byh5netcdf.core.EnumTypefails because thecoresubmodule isn't automatically loaded. This was causing pickling issues with NetCDF4 files (xref developmentseed/titiler-multidim#97).(see also, zarr-developers/zarr-python#3473 for a bug caused by the same behavior)