End of deprecation cycle: default to using new combine kwargs#11076
End of deprecation cycle: default to using new combine kwargs#11076jsignell wants to merge 9 commits intopydata:mainfrom
Conversation
|
I am debating whether to make By making it a no-op I don't mean removing the option, just enforcing that if it's set it is True. This would allow us to remove some code and warnings as well as the tests that exercise the option. |
xarray/util/deprecation_helpers.py
Outdated
| return ( | ||
| f"In a future version of xarray the default value for {self._name} will " | ||
| f"change from {self._name}={self._old!r} to {self._name}={self._new!r}. " | ||
| f"In xarray v2026.02.1 the default value for {self._name} " |
There was a problem hiding this comment.
I think we should put the specific version in this message, but this is just a guess at what that version will be.
|
This change had a big blast radius (every user using |
Yeaaahh fair enough. |
|
Actually I'm going to open a new PR with the docstring and test changes that I would like to salvage. |
PR: pydata#11080 Issue: pydata#11076 Base commit: 3f9ab77 Changed lines: 147
2 participants
It's been almost 6 months and I haven't seen any reports of issues. All the original PR (#10062) did was raise
FutureWarningsthough, so this could still have an impact on people who ignored those.whats-new.rstNew functions/methods are listed inapi.rst