Fix .plot error when using positional args with col and row#11111
Merged
jsignell merged 9 commits intopydata:mainfrom Feb 4, 2026
Merged
Fix .plot error when using positional args with col and row#11111jsignell merged 9 commits intopydata:mainfrom
.plot error when using positional args with col and row#11111jsignell merged 9 commits intopydata:mainfrom
Conversation
jsignell
commented
Jan 28, 2026
| Additional keyword arguments to :py:func:`matplotlib:matplotlib.pyplot.hist`. | ||
|
|
||
| """ | ||
| assert len(args) == 0 |
Member
Author
There was a problem hiding this comment.
I noticed this in passing. Just an old way of saying no positional args.
jsignell
commented
Jan 28, 2026
| def scatter( | ||
| ds: Dataset, | ||
| *args: Any, | ||
| *, |
Member
Author
There was a problem hiding this comment.
I tried to add a test for positional args on scatter but it errored out because it immediately tries to use y to make a dataarray from the dataset. We could fix this and add a deprecation cycle, but since the change went in 3 years ago and it hasn't been fixed yet seems fine to just remove the option for positional args.
jsignell
commented
Jan 28, 2026
jsignell
changed the title
.plot when using positional args with col and row.plot error when using positional args with col and row
dcherian
approved these changes
Feb 3, 2026
jsignell
commented
Feb 4, 2026
jsignell
commented
Feb 4, 2026
tonybaloney
pushed a commit
to tonybaloney/swe-complex-xarray
that referenced
this pull request
Mar 19, 2026
PR: pydata#11111 Issue: pydata#11104 Base commit: 7e11188 Changed lines: 44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dataarray_plot.py#11104whats-new.rst